Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Remove esvu LibJS REPL jobs #24679

Merged
merged 1 commit into from
Jul 7, 2024
Merged

Conversation

BertalanD
Copy link
Member

As of devsnek/esvu#57, esvu now pulls the LibJS binaries from the Ladybird repo, so these artifacts being created has no purpose. As far as I can tell, nothing else uses them.

Maybe if the two LibJS versions start going their separate ways enough to warrant both being available, we could consider re-adding this job. But no point in using up CI resources for that right now.

As of devsnek/esvu#57, `esvu` now pulls the
LibJS binaries from the Ladybird repo, so these artifacts being created
has no purpose. As far as I can tell, nothing else uses them.

Maybe if the two LibJS versions start going their separate ways enough
to warrant both being available, we could consider re-adding this job.
But no point in using up CI resources for that right now.
@github-actions github-actions bot added the 👀 pr-needs-review PR needs review from a maintainer or community member label Jul 7, 2024
@ADKaster ADKaster merged commit 72a1c69 into SerenityOS:master Jul 7, 2024
11 checks passed
@github-actions github-actions bot removed the 👀 pr-needs-review PR needs review from a maintainer or community member label Jul 7, 2024
@BertalanD BertalanD deleted the remove-esvu branch July 7, 2024 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants